Code review comment for lp:~unity-team/unity8/new-scopes-clean-to-trunk

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> > 386 + cacheBuffer: 1404 // 18px * 13gu * 6
> >
> > Why hardcode the gu value to 18px? This is not correct on anything else than
> Mako. Imo it should be:
> >
> > cacheBuffer: units.gu(13) * 6
> >
> > And then I'm still wondering why 13 and 6?
>
> This is a copy and paste from the old Carousels (that are removed in new-
> scopes-cleanup). I agree it could be improved but I do not think it should
> block this merge since basically it is something that was already this way in
> trunk. Maybe we can open a bug about it?

Ok. Let's leave the 13 and 6 and file a bug about it. But can we at least make it work the same on all px/gu values?

« Back to merge proposal