Code review comment for lp:~unity-team/unity8/music-video_renderers
Revision history for this message
| Albert Astals Cid (aacid) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I'm a little worried about how much copied but yet different the code seems to be, i.e. MusicTileStyle and VideoTileStyle labels are "almost" the same but one of them is eliding right and the other center, and of them is bold and the other is not.
Also the icon elements are very similar but not enterily.
Is there no way we can actually reuse most of the stuff here instead of copy&pasting and changing a few lines? Otherwise when we decide leftMargin: units.gu(1) has to be leftMargin: units.gu(2) for a Label or something it's going to be a pain having to find out all the places it was copied and pasted.