Code review comment for lp:~unity-team/unity8/mirCompositor

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> === added file 'qml/Stages/TransformedTabletSpreadDelegate.qml'
> + property bool otherSelected: false
> something selected on the other stage, is it? So both need to animate forward?
> Quick comment would help.

done.

> + // Required to be an item because we're using states on it.
> I think you can use a StateGroup inside a QtObject.

Tried it, doesn't seem to work...

> nextInStack, movedActive and animatedEndDistance could be readonly.
> XTranslate, scale, angle, opacityTransform and topMarginProgress too

nope. The state wants write access to it. See previous comment on readonly props.

>
> + var shouldMoveAway = spreadView.nextInStack >= 0 && movedActive &&
> (ApplicationManager.get(spreadView.nextInStack).stage ===
> ApplicationInfoInterface.MainStage || model.stage ==
> ApplicationInfoInterface.SideStage);
> line too long

done

> Rest of the file looks ok, the math is quite nontrivial but it looks sane. So
> mainly small issues!

« Back to merge proposal