Code review comment for lp:~unity-team/unity8/mirCompositor
Revision history for this message
| Michael Zanetti (mzanetti) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> === modified file 'qml/Stages/
> + visible: progress >= 0 && progress < 1.7
> that magic 1.7 again. Quick comment would be enough probably.
Well there is a comment saying that this the min/max values of progress... Should I duplicate the entire "how I got to those numbers" text?
>
> + var animatedEndDistance = linearAnimation(0, 2, root.endDistance, 0,
> root.progress)
> semicolon
added
>
> === added file 'qml/Stages/
> some more readonly properties...
I don't really agree with this. There could be some of those made readonly, not all. But tbh seems to cause more mess than anything else. Again this is not public API...
The thing with readonly is that you also can't apply any Behavior or state changes on that property any more... Having "angle" readonly, while keeping xTranslate read-write etc doesn't seem like doing any good to me.