Code review comment for lp:~unity-team/unity8/mirCompositor
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> === modified file 'qml/Components
> - property url background: ""
> + property url background: shell.background
> Breaks encapsulation
>
> === modified file 'qml/Shell.qml'
> - background: shell.background
> + //background: shell.background // FIXME: Commenting out as Qt was
> complaining about this line
> I'm not sure breaking encapsulation is better than fixing a warning.
I wasn't just a warning. Shell.qml was failing to load because of it. Thankfully the QML engine bug that caused it must have been fixed in the meantime (likely the one that Albert Alstals fixed) and restoring that line no longer causes any problem.
Fixed.