Code review comment for lp:~unity-team/unity8/mirCompositor

Revision history for this message
Gerry Boland (gerboland) wrote :

=== added file 'qml/Stages/TransformedTabletSpreadDelegate.qml'
+ property bool otherSelected: false
something selected on the other stage, is it? So both need to animate forward? Quick comment would help.

+ // Required to be an item because we're using states on it.
I think you can use a StateGroup inside a QtObject.

nextInStack, movedActive and animatedEndDistance could be readonly. XTranslate, scale, angle, opacityTransform and topMarginProgress too

+ var shouldMoveAway = spreadView.nextInStack >= 0 && movedActive && (ApplicationManager.get(spreadView.nextInStack).stage === ApplicationInfoInterface.MainStage || model.stage == ApplicationInfoInterface.SideStage);
line too long

Rest of the file looks ok, the math is quite nontrivial but it looks sane. So mainly small issues!

review: Needs Fixing

« Back to merge proposal