Code review comment for lp:~unity-team/unity8/mirCompositor

> === modified file 'qml/Stages/SpreadDelegate.qml'
> + border { left: 50; right: 50; top: 50; bottom: 50 }
> No GU?

in this case its pixels in the source image, so no.

>
> + if ((dragVelocity < -600 && distance < -units.gu(8))
> more magic numbers? Are they phone shell specific? Since we use GU for
> distances, doesn't that mean we need to scale velocities against GU too?
> Probably a personal thing, but I do flick apps closed by accident. Can be a
> later bugfix though.

Magic numbers dictated by the design prototype :) Comment added. But you're right, velocity should be given in gu indeed. I've fixed that.

>
> + animation.from = dragArea.distance
> + animation.to = 0
> + root.closed()
> semicolons or no?

yep, added