Code review comment for lp:~unity-team/unity8/mirCompositor

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> === modified file 'qml/Stages/PhoneStage.qml'
> + property bool locked: spreadView.phase == 2
> readonly?

fixed.

> + spreadView.contentX = -spreadView.shift
> + priv.switchToApp(appId)
> nit-pick - semicolons?

fixed

> + if (behavioredIndex == 1 ....
> are these floating point comparisons safe?

Haven't seen any troubles, also this is straight bound to an integer property, just added a Behavior. No floating point calculations involved. I don't think its worth adding some additional fuzziness checks but if you want me to, I can do.

>
> + // Limiting progress to ~0 and 1.7
> 1.7 a bit magic, is that roughly 1 + 0.7 = width of the transformed tile on
> the left?

I tried to improve the comment a bit. Hope its more clear now.

« Back to merge proposal