Code review comment for lp:~unity-team/unity8/mirCompositor
Revision history for this message
| Daniel d'Andrada (dandrader) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
> === modified file 'qml/Shell.qml'
> -FocusScope {
> +Item {
> I'd rather we didn't do this. We're not really doing focus management
> properly, but IMO there's no reason to remove this focusscope.
The reason is that there's absolutely no use for this FocusScope there. Getting rid of unused stuff is always a good thing.
> + // It might technically not be fullyShown but visually it just looks so.
> + property bool roughlyFullyShown: x >= 0 && x <= units.gu(1)
> The purpose if this is a mystery to me. Why is fullyShown not the correct
> thing to use to decide that the spread is interactive? Can we not do something
> more obvious?
To avoid fidgety behavior when the stage moves only a pixel or so: imperceptible to the human eye so from the user's POV it's still fully shown be we would be already unfocusing the app etc.