Code review comment for lp:~unity-team/unity8/mirCompositor

=== modified file 'qml/Stages/SpreadDelegate.qml'
+ // FIXME: I would rather not need to do this, but currently it doesn't get
+ // active focus without it and I don't know why.
+ onFocusChanged: forceSurfaceActiveFocusIfReady();
+ onParentChanged: forceSurfaceActiveFocusIfReady();
+ onEnabledChanged: forceSurfaceActiveFocusIfReady();
+ function forceSurfaceActiveFocusIfReady() {
+ if (surface.focus && surface.parent === surfaceContainer && surface.enabled) {
+ surface.forceActiveFocus();
+ }
+ }
I'm *really* not a fan of this, but as it is a FIXME, and as long as it behaves correctly we'll live with it for now.

+ border { left: 50; right: 50; top: 50; bottom: 50 }
No GU?

+ if ((dragVelocity < -600 && distance < -units.gu(8))
more magic numbers? Are they phone shell specific? Since we use GU for distances, doesn't that mean we need to scale velocities against GU too?
Probably a personal thing, but I do flick apps closed by accident. Can be a later bugfix though.

+ animation.from = dragArea.distance
+ animation.to = 0
+ root.closed()
semicolons or no?