Code review comment for lp:~unity-team/unity8/mirCompositor

Revision history for this message
Gerry Boland (gerboland) wrote :

=== modified file 'qml/Stages/PhoneStage.qml'
+ property bool locked: spreadView.phase == 2
readonly?

+ spreadView.contentX = -spreadView.shift
+ priv.switchToApp(appId)
nit-pick - semicolons?

+ if (behavioredIndex == 1 ....
are these floating point comparisons safe?

+ // Limiting progress to ~0 and 1.7
1.7 a bit magic, is that roughly 1 + 0.7 = width of the transformed tile on the left?

« Back to merge proposal