Code review comment for lp:~unity-team/unity8/mirCompositor

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> Reviewed new KeyHandler code. Looks good.

To be clear, I don't think this is the final thing we need in the end (once we need Keyboard navigation through the shell etc). I'm afraid we have to go back to the "focus mayhem" at that point. However, we also lack policy stuff for handling system keys (like Volume Up/Down) which prevents us to put in place the proper solution just yet, so I think this is a fine solution for now.

« Back to merge proposal