> On 29/10/2015 12:32, Nick Dedekind wrote:
> > These are supposed to be unit tests which are testing the stage aren't they,
> so we shouldn't be testing the decorations.
>
> Kind of. If you skip this part you're missing the
> interactions/integration between the decoration and the Stage. As I
> previously explained. So your test is not wrong, but it's definitely
> less valuable in my opinion.
>
> But ok, won't block because of this.
Valid. I've changed the test to emit the signal from the DecoratedWindow.
I had to fix another bug to do this. where clicking maximise when already maximised will not unmaximise.
> On 29/10/2015 12:32, Nick Dedekind wrote: integration between the decoration and the Stage. As I
> > These are supposed to be unit tests which are testing the stage aren't they,
> so we shouldn't be testing the decorations.
>
> Kind of. If you skip this part you're missing the
> interactions/
> previously explained. So your test is not wrong, but it's definitely
> less valuable in my opinion.
>
> But ok, won't block because of this.
Valid. I've changed the test to emit the signal from the DecoratedWindow.
I had to fix another bug to do this. where clicking maximise when already maximised will not unmaximise.