Merge lp:~unity-team/unity8/fixBlackHeader into lp:unity8

Proposed by Michał Sawicz
Status: Merged
Approved by: Michał Sawicz
Approved revision: 2218
Merged at revision: 2221
Proposed branch: lp:~unity-team/unity8/fixBlackHeader
Merge into: lp:unity8
Prerequisite: lp:~unity-team/unity8/indicator-color-fixes
Diff against target: 107 lines (+11/-4)
4 files modified
debian/control (+4/-4)
qml/Components/Header.qml (+1/-0)
qml/Dash/DashPageHeader.qml (+4/-0)
qml/Stages/Splash.qml (+2/-0)
To merge this branch: bzr merge lp:~unity-team/unity8/fixBlackHeader
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing
Michał Sawicz Approve
Albert Astals Cid Pending
Zoltan Balogh Pending
PS Jenkins bot continuous-integration Pending
Review via email: mp+288176@code.launchpad.net

This proposal supersedes a proposal from 2016-02-29.

Commit message

Update headers for Dash and Splash to work properly with the new UI toolkit release.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, https://code.launchpad.net/~tpeeters/ubuntu-ui-toolkit/headerNoClip/+merge/281738

That is included in the current UITK landing in silo 50. When the changes below for unity8 are approved, we will include the current MR in the landing.

 * Did you perform an exploratory manual test run of your code change and any related functionality?

Yes, tested dash and app splash screen on mako.

 * Did you make sure that your branch does not contain spurious tags?

$ python strip-u8-tags.py lp:~tpeeters/unity8/fixBlackHeader
lp:~tpeeters/unity8/fixBlackHeader: clean

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Not applicable.

 * If you changed the UI, has there been a design review?

UI should look the same as before.

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2144
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/191/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/191/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

Please increase the qtdeclarative5-ubuntu-ui-toolkit-plugin dependency on the debian/control file since if we try to run this code with older versions it will just fail

review: Needs Fixing
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2145
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/192/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/192/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2144
http://jenkins.qa.ubuntu.com/job/unity8-ci/7148/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/6175
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-xenial-touch/563/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/1853
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity8-qmluitest-xenial-amd64/556
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/1748
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/1748
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-amd64-ci/555
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-xenial-i386-ci/554
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-touch/4765
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6186
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/6186/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27004
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-xenial-touch/294/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/561
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-xenial-armhf/561/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/27003

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/7148/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal

FAILED: Continuous integration, rev:2146
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/193/
Executed test runs:

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/193/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Zoltan Balogh (bzoltan) wrote : Posted in a previous version of this proposal
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote : Posted in a previous version of this proposal

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass?
No, needs a newer SDK, running locally before top-approval

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
Tim Peeters (tpeeters) wrote : Posted in a previous version of this proposal

I resubmitted this MR to add the prerequisite to avoid a merge conflict.

Revision history for this message
Albert Astals Cid (aacid) : Posted in a previous version of this proposal
review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
Michał Sawicz (saviq) wrote :

Approving as per superseeded branch.

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2218
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/599/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/336
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/336
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/336
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/790
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/810
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/810
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/804
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/804/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/804
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/804/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/804
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/804/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/804
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/804/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/804
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/804/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/804
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/804/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/599/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2016-03-04 21:04:22 +0000
+++ debian/control 2016-03-04 21:04:22 +0000
@@ -55,7 +55,7 @@
55 qtdeclarative5-qtmultimedia-plugin (>= 5.4.1-1ubuntu19~overlay2),55 qtdeclarative5-qtmultimedia-plugin (>= 5.4.1-1ubuntu19~overlay2),
56 qtdeclarative5-ubuntu-content1,56 qtdeclarative5-ubuntu-content1,
57 qtdeclarative5-ubuntu-settings-components (>= 0.7),57 qtdeclarative5-ubuntu-settings-components (>= 0.7),
58 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1676) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1676),58 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1796) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1796),
59 qtdeclarative5-ubuntu-web-plugin,59 qtdeclarative5-ubuntu-web-plugin,
60 ttf-ubuntu-font-family,60 ttf-ubuntu-font-family,
61Standards-Version: 3.9.461Standards-Version: 3.9.4
@@ -70,7 +70,7 @@
70Package: indicators-client70Package: indicators-client
71Architecture: amd64 armhf i38671Architecture: amd64 armhf i386
72Depends: qmenumodel-qml (>= 0.2.9),72Depends: qmenumodel-qml (>= 0.2.9),
73 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1627) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1627),73 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1796) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1796),
74 unity8 (= ${binary:Version}),74 unity8 (= ${binary:Version}),
75 ${misc:Depends},75 ${misc:Depends},
76 ${shlibs:Depends},76 ${shlibs:Depends},
@@ -128,7 +128,7 @@
128Depends: qml-module-qtquick-layouts,128Depends: qml-module-qtquick-layouts,
129 qtdeclarative5-ubuntu-settings-components (>= 0.7),129 qtdeclarative5-ubuntu-settings-components (>= 0.7),
130 qtdeclarative5-ubuntu-thumbnailer0.1 | ubuntu-thumbnailer-impl,130 qtdeclarative5-ubuntu-thumbnailer0.1 | ubuntu-thumbnailer-impl,
131 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1627) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1627),131 qtdeclarative5-ubuntu-ui-toolkit-plugin (>= 1.3.1796) | qtdeclarative5-ubuntu-ui-toolkit-plugin-gles (>= 1.3.1796),
132 qtdeclarative5-unity-notifications-plugin (>= 0.1.2) | unity-notifications-impl,132 qtdeclarative5-unity-notifications-plugin (>= 0.1.2) | unity-notifications-impl,
133 ubuntu-thumbnailer-impl-0,133 ubuntu-thumbnailer-impl-0,
134 unity-application-impl-13,134 unity-application-impl-13,
@@ -158,7 +158,7 @@
158 python3-fixtures,158 python3-fixtures,
159 python3-gi,159 python3-gi,
160 qttestability-autopilot (>= 1.4),160 qttestability-autopilot (>= 1.4),
161 ubuntu-ui-toolkit-autopilot (>= 1.2.1485+15.04.20150417.1-0ubuntu1),161 ubuntu-ui-toolkit-autopilot (>= 1.3.1796),
162 unity-scope-click,162 unity-scope-click,
163 unity8 (= ${source:Version}),163 unity8 (= ${source:Version}),
164 unity8-fake-env (= ${source:Version}),164 unity8-fake-env (= ${source:Version}),
165165
=== modified file 'qml/Components/Header.qml'
--- qml/Components/Header.qml 2015-07-10 07:47:35 +0000
+++ qml/Components/Header.qml 2016-03-04 21:04:22 +0000
@@ -18,6 +18,7 @@
18import Ubuntu.Components.Themes.Ambiance 1.318import Ubuntu.Components.Themes.Ambiance 1.3
1919
20PageHeadStyle {20PageHeadStyle {
21 // FIXME: Don't use this but PageHeader from Ubuntu.Components 1.3.
21 id: root22 id: root
2223
23 property var styledItem: root24 property var styledItem: root
2425
=== modified file 'qml/Dash/DashPageHeader.qml'
--- qml/Dash/DashPageHeader.qml 2015-12-21 12:14:57 +0000
+++ qml/Dash/DashPageHeader.qml 2016-03-04 21:04:22 +0000
@@ -170,6 +170,7 @@
170 anchors { left: parent.left; right: parent.right }170 anchors { left: parent.left; right: parent.right }
171171
172 PageHeadStyle {172 PageHeadStyle {
173 // FIXME: Replace PageHeadStyle from the Ambiance theme by the new PageHeader from Ubuntu.Components 1.3.
173 id: searchHeader174 id: searchHeader
174 anchors { left: parent.left; right: parent.right }175 anchors { left: parent.left; right: parent.right }
175 opacity: headerContainer.clip || headerContainer.showSearch ? 1 : 0 // setting visible false cause column to relayout176 opacity: headerContainer.clip || headerContainer.showSearch ? 1 : 0 // setting visible false cause column to relayout
@@ -179,6 +180,7 @@
179 property color dividerColor: "transparent" // Doesn't matter as we don't have PageHeadSections180 property color dividerColor: "transparent" // Doesn't matter as we don't have PageHeadSections
180 property color panelColor: background.topColor181 property color panelColor: background.topColor
181 panelForegroundColor: config.foregroundColor182 panelForegroundColor: config.foregroundColor
183 backgroundColor: "transparent"
182 config: PageHeadConfiguration {184 config: PageHeadConfiguration {
183 foregroundColor: root.scopeStyle ? root.scopeStyle.headerForeground : theme.palette.normal.baseText185 foregroundColor: root.scopeStyle ? root.scopeStyle.headerForeground : theme.palette.normal.baseText
184 backAction: Action {186 backAction: Action {
@@ -241,6 +243,7 @@
241 }243 }
242244
243 PageHeadStyle {245 PageHeadStyle {
246 // FIXME: Replace PageHeadStyle from the Ambiance theme by the new PageHeader from Ubuntu.Components 1.3.
244 id: header247 id: header
245 objectName: "innerPageHeader"248 objectName: "innerPageHeader"
246 anchors { left: parent.left; right: parent.right }249 anchors { left: parent.left; right: parent.right }
@@ -251,6 +254,7 @@
251 property color dividerColor: "transparent" // Doesn't matter as we don't have PageHeadSections254 property color dividerColor: "transparent" // Doesn't matter as we don't have PageHeadSections
252 property color panelColor: background.topColor255 property color panelColor: background.topColor
253 panelForegroundColor: config.foregroundColor256 panelForegroundColor: config.foregroundColor
257 backgroundColor: "transparent"
254 config: PageHeadConfiguration {258 config: PageHeadConfiguration {
255 title: root.title259 title: root.title
256 foregroundColor: root.scopeStyle ? root.scopeStyle.headerForeground : theme.palette.normal.baseText260 foregroundColor: root.scopeStyle ? root.scopeStyle.headerForeground : theme.palette.normal.baseText
257261
=== modified file 'qml/Stages/Splash.qml'
--- qml/Stages/Splash.qml 2016-01-20 08:51:48 +0000
+++ qml/Stages/Splash.qml 2016-03-04 21:04:22 +0000
@@ -76,6 +76,7 @@
76 }76 }
7777
78 Ambiance.PageHeadStyle {78 Ambiance.PageHeadStyle {
79 // FIXME: Replace PageHeadStyle by PageHeader from Ubuntu.Components 1.3.
79 id: header80 id: header
80 anchors {81 anchors {
81 left: parent.left;82 left: parent.left;
@@ -86,6 +87,7 @@
86 property color dividerColor: Qt.darker(styledItem.backgroundColor, 1.1)87 property color dividerColor: Qt.darker(styledItem.backgroundColor, 1.1)
87 property color panelColor: Qt.lighter(styledItem.backgroundColor, 1.1)88 property color panelColor: Qt.lighter(styledItem.backgroundColor, 1.1)
88 panelForegroundColor: config.foregroundColor89 panelForegroundColor: config.foregroundColor
90 backgroundColor: "transparent"
89 config: PageHeadConfiguration {91 config: PageHeadConfiguration {
90 id: headerConfig92 id: headerConfig
91 foregroundColor: styledItem.fakeTheme.palette.selected.backgroundText93 foregroundColor: styledItem.fakeTheme.palette.selected.backgroundText

Subscribers

People subscribed via source and target branches