Merge lp:~unity-team/unity8/fix-password-predictive-text into lp:unity8

[Michał Sawicz]

Set the Qt.ImhNoPredictiveText flag on wifi password field, fixes lp:1291575

Set the Qt.ImhNoPredictiveText flag on wifi password field, fixes lp:1291575

[Bill Filler (bfiller)]

* Are there any related MPs required for this MP to build/function as expected? Please list.
NO

 * Did you perform an exploratory manual test run of your code change and any related functionality?
YES

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
NA

 * If you changed the UI, has there been a design review?
NA

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:760
http://jenkins.qa.ubuntu.com/job/unity8-ci/2476/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3859
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3444/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1346
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/997
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1001
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/1001/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/997
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3384
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3886
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3886/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3446
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3446/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5802/console
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4723

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2476/rebuild

review: Needs Fixing (continuous-integration)

[Andrea Cimitan (cimi)]

Thanks Bill, we're fine to merge this with a small TODO linking the bug, something like

// TODO using Qt.ImhNoPredictiveText here until lp #1291575 is fixed for ubuntu-ui-toolkit

review: Needs Fixing

[Bill Filler (bfiller)]

added the TODO comment

[Michał Sawicz (saviq)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes.

 * Did CI run pass? If not, please explain why.
Yes.

review: Approve

[Michał Sawicz (saviq)]

Approving as per the prerequisite. This only fixes whitespace.

review: Approve

=== modified file 'qml/Notifications/NotificationMenuItemFactory.qml'
--- qml/Notifications/NotificationMenuItemFactory.qml	2013-12-23 12:26:18 +0000
+++ qml/Notifications/NotificationMenuItemFactory.qml	2014-04-10 08:50:31 +0000
@@ -66,7 +66,8 @@
             TextField {
                 id: textfield
 
-                inputMethodHints: Qt.ImhNoAutoUppercase
+                // TODO using Qt.ImhNoPredictiveText here until lp #1291575 is fixed for ubuntu-ui-toolkit
+                inputMethodHints: Qt.ImhNoAutoUppercase | Qt.ImhNoPredictiveText
                 anchors.left: parent.left; anchors.right: parent.right
                 echoMode: checkBox.checked ? TextInput.Normal : TextInput.Password
                 height: units.gu(5)