Ubuntu
unity8 package

[osk] predictive text should be disabled on wifi password dialog

Bug #1291575 reported by Bill Filler
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu UX
Fix Released
High
Rae Shambrook
ubuntu-ui-toolkit (Ubuntu)
Confirmed
Undecided
Unassigned
unity8 (Ubuntu)
Fix Released
High
Bill Filler

Bug Description

on the wifi password dialog if you check "show password" and if word prediction/spell checking is on, the user is presented with word ribbon. this should be disabled by setting the Qt.ImNoPredicticveText hint on the entry field

Related branches

lp:~bfiller/unity8/fix-password-predictive-text
Superseded for merging into lp:unity8
Michał Sawicz: Approve
Andrea Cimitan (community): Needs Fixing
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Diff: 15 lines (+3/-2)
1 file modified
qml/Notifications/NotificationMenuItemFactory.qml (+3/-2)
lp:ubuntu/trusty-proposed/unity8
Bill Filler (bfiller)
Changed in unity8 (Ubuntu):
status: New → In Progress
assignee: nobody → Bill Filler (bfiller)
importance: Undecided → High
Revision history for this message
Michał Sawicz (saviq) wrote :

I wonder if this shouldn't be solved on the SDK level... I'm sure that there are plenty of password entry fields already that should have those set... Affecting UITK.

Revision history for this message
Bill Filler (bfiller) wrote :

So the problem is this:
                echoMode: checkBox.checked ? TextInput.Normal : TextInput.Password

For TextInput.Password fields predictive text is disabled system wide. But when the echo mode is set then it's a normal text field so the hints need to be set explicitliy. Maybe echoMode is not being used correctly here?

Revision history for this message
Michał Sawicz (saviq) wrote : Re: [Bug 1291575] Re: predictive text should be disabled on wifi password dialog

On 12.03.2014 22:15, Bill Filler wrote:
> For TextInput.Password fields predictive text is disabled system wide.
> But when the echo mode is set then it's a normal text field so the hints
> need to be set explicitliy. Maybe echoMode is not being used correctly
> here?

So question here is probably whether we want to allow/support password
fields with the "Show passwords" option in general - if yes, we should
solve this on the SDK level some way. If not, it's fine to stay here.

Anders (eddiedog988)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote : Re: predictive text should be disabled on wifi password dialog

This bug was fixed in the package unity8 - 7.85+14.04.20140410.1-0ubuntu1

---------------
unity8 (7.85+14.04.20140410.1-0ubuntu1) trusty; urgency=medium

  [ Didier Roche ]
  * Resync trunk with previous revert upload

  [ Michał Sawicz ]
  * Set the Qt.ImhNoPredictiveText flag on wifi password field, fixes
    lp:1291575 (LP: #1291575)

  [ Albert Astals ]
  * Take into account the originY when specifying the delegate ranges
    Fixes bug #1300302 (LP: #1300302)

  [ CI bot ]
  * Resync trunk

  [ Allan LeSage ]
  * Swiping open an indicator must show its correct title--protect
    against lp:1253804 . (LP: #1253804)

  [ Alexander Sack ]
  * Fix TypeError: issue seen in system_integration autopilot test on
    image 279. (LP: #1303685)

  [ Bill Filler ]
  * Set the Qt.ImhNoPredictiveText flag on wifi password field, fixes
    lp:1291575 (LP: #1291575)

  [ Leo Arias ]
  * Added a search autopilot helper.

  [ Michael Terry ]
  * Provide a all-in-one script for getting a device to an unlocked
    state.
 -- Ubuntu daily release <email address hidden> Thu, 10 Apr 2014 10:03:31 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
Zoltan Balogh (bzoltan)
affects: ubuntu-ui-toolkit (Ubuntu) → ubuntu-ui-toolkit
Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Confirmed
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Revision history for this message
Cris Dywan (kalikiana) wrote :

Once more the question, do we want universal "show password" and if so what design?

Magdalena Mirowicz (magdalena-mirowicz)
Changed in ubuntu-ux:
status: New → Incomplete
status: Incomplete → Triaged
importance: Undecided → High
assignee: nobody → Paty Davila (dizzypaty)
John Lea (johnlea)
summary: - predictive text should be disabled on wifi password dialog
+ [osk] predictive text should be disabled on wifi password dialog
Changed in ubuntu-ux:
assignee: Paty Davila (dizzypaty) → Rae Shambrook (raecontreras)
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Christian, it might be useful to have an "allowShowing" or similar flag on password fields, which has a standard visual design and prevents predictive text and spellchecking. <http://www.lukew.com/ff/entry.asp?1941> If/when that is implemented, this dialog should be updated to use it. But I think that's really a separate issue from preventing predictive text for this particular field in this particular dialog.

Rae Shambrook (raecontreras)
Changed in ubuntu-ux:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.