Unity 8

Code review comment for lp:~unity-team/unity8/dash-as-app

  1. dash-as-app
  2. Merge into trunk
Revision history for this message
Daniel d'Andrada (dandrader) wrote :

"""
Q_SIGNALS:
    void setCurrentScope(const QString &scopeId, bool animate, bool reset);
"""

Naming signals like functions is never a good thing. I would make an effort to name it like a signal. "requestedScopeAsCurrent" or even "setCurrentScopeCalled" would do it.

review: Needs Fixing

« Back to merge proposal