Code review comment for lp:~unity-team/unity8/carousel-shader

Revision history for this message
Andrea Cimitan (cimi) wrote :

> My comment was not about the custom durations vs "standarized" Ubuntu
> Animation duration, which i agree we should fix and use, let's say
> UbuntuAnimation.FastDuration (165) instead of 200, and i do agree we can do
> that later.
>
> But then there is the question i wanted to make (and maybe it did not get
> through)
>
> "Should the ShaderEffect animation always have exactly the same duration than
> the OpenEffect one in GenericScopeView.qml?"
> Because if they should, switching to UbuntuAnimation.XYZ won't help here
> (since later someone could change one to UbuntuAnimation.BriskAnimation and
> forget about the other), if they have to be the same we actually need to make
> sure there's a property we can bind to each other so they are always in sync.

I don't think it's a requirement... we can have them async

« Back to merge proposal