Code review comment for lp:~unity-team/unity/unity.hide-cleanup

Revision history for this message
Alejandro PiƱeiro (apinheiro) wrote :

I have just tested it, and the orca support on the launcher is still working (although right now this is true with at-spi2, not with at-spi). As I told Jason Smith on IRC, current a11y support on the Launcher is based on the icon selection change (signal selection_change) and the Launcher having the focus (signals OnStartFocus and OnEndFocus) and this branch doesn't modify it.

In the case of places, right now the support is zero, as I just made some user-tests, and start to review the object hierarchy. But as the real support is zero, it doesn't matter if it changes suddenly.

So from my part it is ok.

Anyway, this also touches the Panel. So as Rodrigo was the one implementing the a11y support for the panel-service, I will let him to review this part.

review: Approve

« Back to merge proposal