Merge lp:~unity-team/unity/unity.fix-menu-item-reference-count into lp:unity

[Jay Taoko]

Unref item returned from menu_item_from_dbusmenuitem. They have an extra reference that stop them from being properly deleted.

[Neil J. Patel (njpatel)]

Approved, looks good.

review: Approve

=== modified file 'unity-private/launcher/quicklist-controller.vala'
--- unity-private/launcher/quicklist-controller.vala	2010-09-21 10:37:25 +0000
+++ unity-private/launcher/quicklist-controller.vala	2010-09-21 16:02:41 +0000
@@ -227,8 +227,14 @@
                 foreach (Dbusmenu.Menuitem menuitem in menu_items)
                   {
                     var view_menuitem = menu_item_from_dbusmenuitem (menuitem);
+                    
                     if (view_menuitem != null)
-                      get_view ().prepend (view_menuitem, false);
+                      {
+                        get_view ().prepend (view_menuitem, false);
+                        // Items returned from menu_item_from_dbusmenuitem have an extra reference
+                        // stopping them from being properly deleted. Remove that reference here.
+                        view_menuitem.unref ();
+                      }
                   }
                 menu_items.reverse ();
               }
@@ -251,9 +257,13 @@
                   foreach (Dbusmenu.Menuitem menuitem in menu_items)
                     {
                       var view_menuitem = menu_item_from_dbusmenuitem (menuitem);
+                      
                       if (view_menuitem != null)
                         {
                           get_view ().append (view_menuitem, false);
+                          // Items returned from menu_item_from_dbusmenuitem have an extra reference
+                          // stopping them from being properly deleted. Remove that reference here.
+                          view_menuitem.unref ();
                         }
                     }
                 }