Merge lp:~unity-team/unity/unity.fix-604505-2 into lp:unity

Proposed by Mirco Müller
Status: Merged
Approved by: Gord Allott
Approved revision: no longer in the source branch.
Merged at revision: 526
Proposed branch: lp:~unity-team/unity/unity.fix-604505-2
Merge into: lp:unity
Diff against target: 38 lines (+28/-0)
1 file modified
unity-private/panel/panel-indicator-object-entry-view.vala (+28/-0)
To merge this branch: bzr merge lp:~unity-team/unity/unity.fix-604505-2
Reviewer Review Type Date Requested Status
Gord Allott (community) Approve
Review via email: mp+36151@code.launchpad.net

Description of the change

For the case when a program with insensitive menus is started... upon initial focus insensitive menus were reactive still. With this patch this is no longer the case. Initial insensitive menus are neither accessable with the mouse nor with the keyboard-navigation.Tested with gnome-dictionary and empathy. Fixes LP: #604505

To post a comment you must log in.
Revision history for this message
Gord Allott (gordallott) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'unity-private/panel/panel-indicator-object-entry-view.vala'
2--- unity-private/panel/panel-indicator-object-entry-view.vala 2010-09-17 15:31:25 +0000
3+++ unity-private/panel/panel-indicator-object-entry-view.vala 2010-09-21 14:41:12 +0000
4@@ -43,6 +43,34 @@
5 spacing:3,
6 homogeneous:false,
7 reactive:true);
8+
9+ if (entry.label != null)
10+ {
11+ if ((entry.label.get_flags () & Gtk.WidgetFlags.SENSITIVE) != 0)
12+ {
13+ this.reactive = true;
14+ this.skip = false;
15+ }
16+ else
17+ {
18+ this.reactive = false;
19+ this.skip = true;
20+ }
21+ }
22+
23+ if (entry.image != null)
24+ {
25+ if ((entry.image.get_flags () & Gtk.WidgetFlags.SENSITIVE) != 0)
26+ {
27+ this.reactive = true;
28+ this.skip = false;
29+ }
30+ else
31+ {
32+ this.reactive = false;
33+ this.skip = true;
34+ }
35+ }
36 }
37
38 ~IndicatorObjectEntryView ()