Merge lp:~unity-team/unity/unity.dim-launcher-icons into lp:unity

Proposed by Andrea Cimitan
Status: Merged
Approved by: Andrea Cimitan
Approved revision: no longer in the source branch.
Merged at revision: 2168
Proposed branch: lp:~unity-team/unity/unity.dim-launcher-icons
Merge into: lp:unity
Diff against target: 48 lines (+6/-6)
2 files modified
plugins/unityshell/src/IconRenderer.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+5/-5)
To merge this branch: bzr merge lp:~unity-team/unity/unity.dim-launcher-icons
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+98880@code.launchpad.net

Commit message

Set 0.2 as new alpha value for dimmed icons, apply tweaks to edges

Description of the change

Set 0.2 as new alpha value for dimmed icons, apply tweaks to edges

Before: http://i.imgur.com/qYNSZ.png
After: http://i.imgur.com/CmIWu.png

Signed-off by visual design.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks very good.
Thanks.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'plugins/unityshell/src/IconRenderer.cpp'
--- plugins/unityshell/src/IconRenderer.cpp 2012-03-21 12:31:11 +0000
+++ plugins/unityshell/src/IconRenderer.cpp 2012-03-22 17:04:21 +0000
@@ -510,7 +510,7 @@
510 edge->GetDeviceTexture(),510 edge->GetDeviceTexture(),
511 edge_color,511 edge_color,
512 edge_tile_colorify,512 edge_tile_colorify,
513 arg.alpha,513 arg.alpha * arg.alpha, // Dim edges of semi-transparent tiles
514 force_filter,514 force_filter,
515 tile_transform);515 tile_transform);
516 // end tile draw516 // end tile draw
517517
=== modified file 'plugins/unityshell/src/Launcher.cpp'
--- plugins/unityshell/src/Launcher.cpp 2012-03-21 14:44:41 +0000
+++ plugins/unityshell/src/Launcher.cpp 2012-03-22 17:04:21 +0000
@@ -879,7 +879,7 @@
879{879{
880 float desat_value = IconDesatValue(icon, current);880 float desat_value = IconDesatValue(icon, current);
881 arg.icon = icon.GetPointer();881 arg.icon = icon.GetPointer();
882 arg.alpha = 0.5f + 0.5f * desat_value;882 arg.alpha = 0.2f + 0.8f * desat_value;
883 arg.saturation = desat_value;883 arg.saturation = desat_value;
884 arg.colorify = nux::color::White;884 arg.colorify = nux::color::White;
885 arg.running_arrow = icon->GetQuirk(AbstractLauncherIcon::QUIRK_RUNNING);885 arg.running_arrow = icon->GetQuirk(AbstractLauncherIcon::QUIRK_RUNNING);
@@ -903,9 +903,9 @@
903 icon->GetIconType() == AbstractLauncherIcon::TYPE_EXPO;903 icon->GetIconType() == AbstractLauncherIcon::TYPE_EXPO;
904904
905 // trying to protect against flickering when icon is dragged from dash LP: #863230905 // trying to protect against flickering when icon is dragged from dash LP: #863230
906 if (arg.alpha < 0.5)906 if (arg.alpha < 0.2)
907 {907 {
908 arg.alpha = 0.5;908 arg.alpha = 0.2;
909 arg.saturation = 0.0;909 arg.saturation = 0.0;
910 }910 }
911911
@@ -997,9 +997,9 @@
997 arg.alpha *= drop_dim_value;997 arg.alpha *= drop_dim_value;
998998
999 // trying to protect against flickering when icon is dragged from dash LP: #863230999 // trying to protect against flickering when icon is dragged from dash LP: #863230
1000 if (arg.alpha < 0.5)1000 if (arg.alpha < 0.2)
1001 {1001 {
1002 arg.alpha = 0.5;1002 arg.alpha = 0.2;
1003 arg.saturation = 0.0;1003 arg.saturation = 0.0;
1004 }1004 }
10051005