Merge lp:~unity-team/unity/unity.dim-launcher-icons into lp:unity

Proposed by Andrea Cimitan
Status: Merged
Approved by: Andrea Cimitan
Approved revision: no longer in the source branch.
Merged at revision: 2168
Proposed branch: lp:~unity-team/unity/unity.dim-launcher-icons
Merge into: lp:unity
Diff against target: 48 lines (+6/-6)
2 files modified
plugins/unityshell/src/IconRenderer.cpp (+1/-1)
plugins/unityshell/src/Launcher.cpp (+5/-5)
To merge this branch: bzr merge lp:~unity-team/unity/unity.dim-launcher-icons
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Review via email: mp+98880@code.launchpad.net

Commit message

Set 0.2 as new alpha value for dimmed icons, apply tweaks to edges

Description of the change

Set 0.2 as new alpha value for dimmed icons, apply tweaks to edges

Before: http://i.imgur.com/qYNSZ.png
After: http://i.imgur.com/CmIWu.png

Signed-off by visual design.

To post a comment you must log in.
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks very good.
Thanks.

review: Approve
Revision history for this message
Unity Merger (unity-merger) wrote :

No commit message specified.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/unityshell/src/IconRenderer.cpp'
2--- plugins/unityshell/src/IconRenderer.cpp 2012-03-21 12:31:11 +0000
3+++ plugins/unityshell/src/IconRenderer.cpp 2012-03-22 17:04:21 +0000
4@@ -510,7 +510,7 @@
5 edge->GetDeviceTexture(),
6 edge_color,
7 edge_tile_colorify,
8- arg.alpha,
9+ arg.alpha * arg.alpha, // Dim edges of semi-transparent tiles
10 force_filter,
11 tile_transform);
12 // end tile draw
13
14=== modified file 'plugins/unityshell/src/Launcher.cpp'
15--- plugins/unityshell/src/Launcher.cpp 2012-03-21 14:44:41 +0000
16+++ plugins/unityshell/src/Launcher.cpp 2012-03-22 17:04:21 +0000
17@@ -879,7 +879,7 @@
18 {
19 float desat_value = IconDesatValue(icon, current);
20 arg.icon = icon.GetPointer();
21- arg.alpha = 0.5f + 0.5f * desat_value;
22+ arg.alpha = 0.2f + 0.8f * desat_value;
23 arg.saturation = desat_value;
24 arg.colorify = nux::color::White;
25 arg.running_arrow = icon->GetQuirk(AbstractLauncherIcon::QUIRK_RUNNING);
26@@ -903,9 +903,9 @@
27 icon->GetIconType() == AbstractLauncherIcon::TYPE_EXPO;
28
29 // trying to protect against flickering when icon is dragged from dash LP: #863230
30- if (arg.alpha < 0.5)
31+ if (arg.alpha < 0.2)
32 {
33- arg.alpha = 0.5;
34+ arg.alpha = 0.2;
35 arg.saturation = 0.0;
36 }
37
38@@ -997,9 +997,9 @@
39 arg.alpha *= drop_dim_value;
40
41 // trying to protect against flickering when icon is dragged from dash LP: #863230
42- if (arg.alpha < 0.5)
43+ if (arg.alpha < 0.2)
44 {
45- arg.alpha = 0.5;
46+ arg.alpha = 0.2;
47 arg.saturation = 0.0;
48 }
49