Code review comment for lp:~unity-team/unity/unity-sru-fix-mem-leaks

Those changes to unityshell.cpp are similar to what I had implemented and was going to move into a new bug at some point.

Two concerns though:

1. layout should now be a local variable, because it is effectively lost to the UnityScreen class once it is assigned to the launcherWindow. The layout member should then be removed completely. Alternatively, if you keep layout as a member then a more clear and elegant solution is to reintroduce its UnReference and just give it a SinkReference too.

2. My fixes to unityshell.cpp also have this leak-fix you seem to be missing:

   LOGGER_START_PROCESS ("initLauncher-Panel");
   self->panelController = new PanelController ();
+ self->panelController->SinkReference();
   self->AddChild (self->panelController);
   LOGGER_END_PROCESS ("initLauncher-Panel");

Maybe I was mistaken?...