Code review comment for lp:~unity-team/unity/phablet.test_greeter-clock

Revision history for this message
Andrea Cimitan (cimi) wrote :

> * I'd say it would make sense to change __date to something predefined and
> then actually check if the labels also change to the wanted value
>
> * The code itself updates the clock only once per minute... That's not enough
> precision for a clock imho... I'd say 5 seconds or something would better
> (Just a notice as we are touching the code anyways... You decide if you want
> to fix that now or not)
>
> I would probably add something like this:
>
> - set clock to invisible => timer is stopped
> - change __date to something else than the current date
> - set clock to visible
> - check if time is updated properly

We save battery by not updating the clock every 5 seconds... isn't it?

« Back to merge proposal