On Fri, 08 Apr 2011 01:42:07 you wrote: > +bool > +PlaceFactoryFile::DoSortThemMister (Place *aa, Place *bb) > +{ > +#define FIRST "/com/canonical/unity/applicationsplace" > +#define SECOND "/com/canonical/unity/filesplace" > +
For the love of clean code, what is wrong with:
static const char* const apps_place = "/com/canonical/unity/applicationsplace"; static const char* const files_place = "/com/canonical/unity/filesplace";
#defines are brutal hammers that just aren't needed in places like this.
« Back to merge proposal
On Fri, 08 Apr 2011 01:42:07 you wrote: le::DoSortThemM ister (Place *aa, Place *bb) /unity/ applicationspla ce" /unity/ filesplace"
> +bool
> +PlaceFactoryFi
> +{
> +#define FIRST "/com/canonical
> +#define SECOND "/com/canonical
> +
For the love of clean code, what is wrong with:
static const char* const apps_place = /unity/ applicationspla ce"; /unity/ filesplace" ;
"/com/canonical
static const char* const files_place = "/com/canonical
#defines are brutal hammers that just aren't needed in places like this.