Code review comment for lp:~unity-team/unity/autohide-load-934514

Marco Trevisan (TreviƱo) (3v1n0) wrote :

 auto hide_all_launchers = [&]()
10 + {
11 + for (auto launcher : launchers)
12 + launcher->ForceReveal(false);
13 + return true;
14 + };
15 + sources_.AddTimeout(3000, hide_all_launchers);

Whi is this timeout always running every 3 seconds?
I'm not sure this is really needed (or a good thing).

Also, probably you could add a sort of unit tests in test_launcher_controller (checking if the force-reveal quirk is correctly set on the launcher's hide machine)...

« Back to merge proposal