Code review comment for lp:~unity-team/ubuntu-ui-toolkit/dynamic-grid-unit

Revision history for this message
Cris Dywan (kalikiana) wrote :

> > However uclabel.cpp we need to test.
>
> Added a test that proves the change is needed (fails with the old code). None
> of the existing tests regresses. Is that enough?

Perfect!

review: Approve

« Back to merge proposal