Code review comment for lp:~unity-team/ubuntu-ui-toolkit/dynamic-grid-unit

+++ src/Ubuntu/Components/1.2/OptionSelectorDelegate.qml
+++ src/Ubuntu/Components/Themes/Ambiance/1.2/SheetForegroundStyle.qml

Unsure if those 1.2 bits should be done. Arguably they are not critical fixes and it's better to avoid changing that version.

The Qt.binding pattern seems sensible. Probably not unit-testable as they all affect visuals which we don't test for exact values anyway.
However uclabel.cpp we need to test. We had a bug before with defaults, not the size but the color. See tests/unit_x11/tst_components/tst_label_extras.qml. More generally size-related cases are covered by tests/unit/tst_components/tst_label13.qml. I'm guessing this would reproduce by changing the font once or twice.