Code review comment for lp:~unity-team/ubuntu-system-settings/welcome-wizard

> We need a way to edit/add/remove users on at least tablet and desktop. The plugin is meant to do that, even
> for the moment it's limited to change names. I imagine we will have a page on the system settings to edit
> the users indeed.
> Icon will get updated when we'll add that page I believe, in the meanwhile it's there as a placeholder but
> it's hidden to the user

Having a plugin to handle account changes is fine, that should be a backend (like for other panels), no a panel with a .settings. Not that in the current version the placeholder is not hidden to the user, that merge is adding an account icon in the settings grid which is not in the design, duplicating an icon (next to online account) and giving an empty/not working page when clicked

> If you accept that welcome-wizard will be improved incrementally, please overlook this section of code.

Ok, fair enough. If we workaround an OSK bug I would like at least a bug reference in a code comment though...

> What's the convention for marking non-public variables? It looks like you just don't bother?

Right, those sources are standalone UIs, not re-usable components, so by definition everything is private to that only user...

BTW I would still welcome tips on how to actually run/test that code on a desktop (or do I need to build a package and install it on the device to test?)