> Why did you remove that chunk from UbuntuSurface constructor in
> src/ubuntumirclient/window.cpp? In any case that removal is unrelated to DPR
> work.
>
> """
> auto geom = mWindow->geometry();
> geom.setWidth(parameters.width);
> geom.setHeight(parameters.height);
> if (mWindowState == Qt::WindowFullScreen) {
> geom.setY(0);
> } else {
> geom.setY(panelHeight());
> }
> """
It was a bit related. I wanted to prevent UbuntuSurface having any knowledge of device-indepedent pixels, I wanted it to be purely pixel based. UbuntuSurface pretty much a wrapper for a MirSurface. So that small refactor allowed me to do that, plus eliminate a small bit of duplicate code.
> Why did you remove that chunk from UbuntuSurface constructor in ient/window. cpp? In any case that removal is unrelated to DPR >geometry( ); parameters. width); parameters. height) ; creen) { panelHeight( ));
> src/ubuntumircl
> work.
>
> """
> auto geom = mWindow-
> geom.setWidth(
> geom.setHeight(
> if (mWindowState == Qt::WindowFullS
> geom.setY(0);
> } else {
> geom.setY(
> }
> """
It was a bit related. I wanted to prevent UbuntuSurface having any knowledge of device-indepedent pixels, I wanted it to be purely pixel based. UbuntuSurface pretty much a wrapper for a MirSurface. So that small refactor allowed me to do that, plus eliminate a small bit of duplicate code.