Code review comment for lp:~unity-team/qtmir/qtmir.api

Revision history for this message
Gerry Boland (gerboland) wrote :

+class BasicSetDisplayConfigurationStorage
+{
+public:
+ explicit BasicSetDisplayConfigurationStorage(DisplayConfigurationStorageBuilder const& builder);
+ ~BasicSetDisplayConfigurationStorage() = default;
+
+ void operator()(QMirServer& server);

You're making your life harder having the builder-applyer take QMirServer, instead of mir::Server. All of MirAL's building blocks use mir::Server, so if we go this route, we end up having to replace all of MirAL's bits. I think that's a bad idea.

review: Needs Fixing

« Back to merge proposal