> + qWarning() << "Dash doesn't seem to be running... Ignoring."; > By your own edict, needs fixing :) >
fixed
> + && m_sideStageApplication != dashApp) { > possible?? I hope not
not atm, but yeah, should be according to design.
> > + if (m_dashActive && application->appId() == "unity8-dash") { > + return false; > + } > resumeApplication should have this too, no?
I don't think so...
> > > Test for the new dashActive property would be good. And test to make sure dash > isn't changed by suspendApplication & resumeApplication
done
« Back to merge proposal
> + qWarning() << "Dash doesn't seem to be running... Ignoring.";
> By your own edict, needs fixing :)
>
fixed
> + && m_sideStageAppl ication != dashApp) {
> possible?? I hope not
not atm, but yeah, should be according to design.
> >appId( ) == "unity8-dash") {
> + if (m_dashActive && application-
> + return false;
> + }
> resumeApplication should have this too, no?
I don't think so...
>
>
> Test for the new dashActive property would be good. And test to make sure dash
> isn't changed by suspendApplication & resumeApplication
done