Code review comment for lp:~unity-team/qtmir/fix-some-lifecycle-bugs

Revision history for this message
Gerry Boland (gerboland) wrote :

+ qWarning() << "Dash doesn't seem to be running... Ignoring.";
By your own edict, needs fixing :)

+ && m_sideStageApplication != dashApp) {
possible?? I hope not

+ if (m_dashActive && application->appId() == "unity8-dash") {
+ return false;
+ }
resumeApplication should have this too, no?

Test for the new dashActive property would be good. And test to make sure dash isn't changed by suspendApplication & resumeApplication

review: Needs Fixing

« Back to merge proposal