Code review comment for lp:~unity-team/qtmir/dpr

Revision history for this message
Gerry Boland (gerboland) wrote :

> The only way I see of saving MirSurface from knowing about DPR is passing it
> the event data directly as parameters instead of giving it the whole QEvent.
>
> Eg:
>
> MirSurface::mouseMoveEvent(QMouseEvent *event, qreal dpr)
>
> Would be:
>
> MirSurface::mouseMoveEvent(Qt::MouseButtons buttons, ulong timestamp,
> Qt::KeyboardModifiers modifiers, int x, int y)
>
> Which is actually not a bad thing.

For touch events too?

« Back to merge proposal