Code review comment for lp:~unity-team/platform-api/devel-for-qtmircompositor

Revision history for this message
Ricardo Mendoza (ricmm) wrote :

Few things:

1. If we can avoid breaking ABI, lets avoid breaking ABI. Please lets just add new functions for window event handling in addition to the existing input event ones, just mark them as deprecated in their comments. Not a big commitment to ABI stability, but in this case it looks relatively easy to *not* break it.

2. All new functions need to have stubs provided in the other modules (testbackend, for example). They also need to be added to the base ubuntu_application_api.cpp source that builds the base SO from macros. window_is_focused is not there.

3. All module_version.h files need to be updated the reflect the version. Same goes for base_module.h, neither of these are modified in here.

review: Needs Fixing

« Back to merge proposal