Code review comment for lp:~unity-team/nux/nux-fix-708020

> Can I strongly suggest that you reorder the two parameter SetPadding?
> CSS for two values has (top and bottom, left and right) as the pair.
> It would be nice to have consistency here.
>

Will do.

> It also appears that the double click time is hard coded. Is there any way to
> query the system? Can people configure their double click time?

Yes, it is hard-coded for now. I need to figure out where to get it from, or simply let Unity set it.

> Re: line 425, why sleep for a second once you have been told that the test is
> ready to go?
>
> Also, why sleep for a second before terminating? This is just strange.

Due to the asynchronous nature of X, I have to resort to this. I spent some time trying to figure when I can be certain that a window is realized. But that is hard to do.
The tests are very sensible to timings. I do the need to sleep the testing thread to leave some time for the window thread to finish processing events.

> What is the purpose of tests/test-view.cpp?
>
> Perhpas a comment at the top of the test file as to its purpose would help a
> lot.

Will do.

> It looks like this test is testing multiple things. You are defining shaders
> and recording events.

Only using a shader, not testing it. The TestView class will be re-used when I do rendering tests.