Nux

Code review comment for lp:~unity-team/nux/nux-fix-708020

Revision history for this message
Tim Penhey (thumper) wrote :

Can I strongly suggest that you reorder the two parameter SetPadding?
CSS for two values has (top and bottom, left and right) as the pair.
It would be nice to have consistency here.

It also appears that the double click time is hard coded. Is there any way to
query the system? Can people configure their double click time?

Re: line 425, why sleep for a second once you have been told that the test is
ready to go?

Also, why sleep for a second before terminating? This is just strange.

What is the purpose of tests/test-view.cpp?

Perhpas a comment at the top of the test file as to its purpose would help a
lot.

It looks like this test is testing multiple things. You are defining shaders
and recording events.

review: Needs Information

« Back to merge proposal