Code review comment for lp:~unity-team/libusermetrics/end-to-end

224 -libusermetrics (2.0.0-0ubuntu1) UNRELEASED; urgency=medium
225 +libusermetrics (1.2.0-0ubuntu1) UNRELEASED; urgency=medium

That looks wrong?

=====

1656 +static QRegularExpression CLICK_REGEX(
1657 + "^[a-z0-9][a-z0-9+.-]+_[a-zA-Z0-9+.-]+_[0-9][a-zA-Z0-9.+:~-]*$");
1658 +

1815 +static QRegularExpression CLICK_REGEX(
1816 + "^[a-z0-9][a-z0-9+.-]+_[a-zA-Z0-9+.-]+_[0-9][a-zA-Z0-9.+:~-]*$");

Seeing a regex like that makes me twinge already, but having it twice!

=====

2086 + return new InfographicListImpl("/var/lib/usermetrics/");

Do we want that hardcoded? Isn't there somewhere we could request the /var/lib/ part from?

=====

2132 + * Given a user ID, this class watches the corresponding
2133 + *

You fell asleep there, did you?

=====

2139 + * @brief The current username selected.
2140 + */
2141 +Q_PROPERTY(unsigned int uid READ uid WRITE setUid NOTIFY uidChanged FINAL)

User Id, not username.