Merge lp:~unity-team/compiz/compiz.no_fallback into lp:~compiz/compiz/ubuntu

Proposed by Sam Spilsbury
Status: Merged
Merged at revision: 592
Proposed branch: lp:~unity-team/compiz/compiz.no_fallback
Merge into: lp:~compiz/compiz/ubuntu
Diff against target: 34 lines (+1/-11)
1 file modified
debian/compiz-decorator (+1/-11)
To merge this branch: bzr merge lp:~unity-team/compiz/compiz.no_fallback
Reviewer Review Type Date Requested Status
Jay Taoko (community) Approve
compiz packagers Pending
Review via email: mp+57039@code.launchpad.net

Description of the change

Don't leave the user without a shell if they didn't install a decorator - instead just warn about the fact that they have no compiz-gnome or compiz-kde installed.

To post a comment you must log in.
Revision history for this message
Jay Taoko (jaytaoko) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/compiz-decorator'
--- debian/compiz-decorator 2011-03-23 07:35:34 +0000
+++ debian/compiz-decorator 2011-04-09 03:11:34 +0000
@@ -21,8 +21,6 @@
21# Contributions by: crdlb21# Contributions by: crdlb
22#22#
23COMPIZ_BIN_PATH=/usr/bin/23COMPIZ_BIN_PATH=/usr/bin/
24KWIN=`which kwin`
25METACITY="/usr/bin/metacity"
2624
27#25#
28# Default to gtk/kde4-window-decorator26# Default to gtk/kde4-window-decorator
@@ -30,14 +28,6 @@
30USE_EMERALD="no"28USE_EMERALD="no"
31DECORATOR=""29DECORATOR=""
3230
33#Do not leave users without decoration if decorator fails
34if [ "$DESKTOP_SESSION" = "kde" ]; then
35 FALLBACKWM="${KWIN}"
36else
37 FALLBACKWM="${METACITY}"
38fi
39FALLBACKWM_OPTIONS=" --replace"
40
41#31#
42# Set to yes to enable verbose32# Set to yes to enable verbose
43#33#
@@ -92,6 +82,6 @@
92 exec ${COMPIZ_BIN_PATH}$DECORATOR "$@"82 exec ${COMPIZ_BIN_PATH}$DECORATOR "$@"
93else83else
94 verbose "Found no decorator to start\n"84 verbose "Found no decorator to start\n"
95 exec $FALLBACKWM $FALLBACKWM_OPTIONS85 verbose "This usually means no decorator is installed - please install one of either compiz-gnome or compiz-kde"
96fi86fi
9787

Subscribers

People subscribed via source and target branches

to all changes: