unity-scopes-shell

Code review comment for lp:~unity-api-team/unity-scopes-shell/scope-settings

Revision history for this message

Michal Hruby (mhr3) wrote on 2014-07-09:

110 + new SettingsModel(QDir::home().filePath(".local/share"), id(),
111 + scopeVariantToQVariant(settings_definitions), this));

Isn't the .local/share/scope_id just a symlink to /opt/... for click-packaged scopes? Can unity even write in there?

211 + QVariantMap data = it.toMap();

Can we rely on the data being valid? Shouldn't it check first that all the necessary keys are in there?

234 + m_timers[id] = timer;

A timer per-setting? Why's that needed?

review: Needs Information