unity-scopes-shell

Code review comment for lp:~unity-api-team/unity-scopes-shell/scope-harness

  1. scope-harness
  2. Merge into trunk
Revision history for this message
Paweł Stołowski (stolowski) wrote :

693 // we need to delay actual deletion of Scope object so that shell can animate it
694 - QTimer::singleShot(1000 * SCOPE_DELETE_DELAY, (*it), SLOT(deleteLater()));
695 + QTimer::singleShot(1000 * SCOPE_DELETE_DELAY, (*it).data(), SLOT(deleteLater()));
696 it = m_scopes.erase(it);

I think that will not work anymore, because erasing from m_scopes will just invoke deleteLater immediately?

« Back to merge proposal