Code review comment for lp:~unity-api-team/ubuntu-system-settings/morenetworks

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

> To say the testing is not in the best possible form is a bit of an
> understatement. We need to have something here. This is two major features
> landing in one branch without so much as a single test. I will need to think a
> bit more about how to solve the unit testing problem. But definitely some
> high-level tests can be written with autopilot. I appreciate you guys might
> not have the experience with this, so I will look at contributing some myself.

The problem is that we don't have a comprehensive "mock" of NetworkManager which would implement the NM API close enough functionality wise to actual NM and we can't use actual NM as it deals with hardware directly and we can't set up a testing hardware environment.

This is a known problem and we need to tackle it at some point, but right now the effort required to do such meaningful mocking far exceeds the complexity of the code under testing and would take weeks to complete.

I will augment the system-settings manual test list to cover these cases so we get at least manual testing for them.

« Back to merge proposal