Code review comment for lp:~unity-api-team/ubuntu-system-settings/hotspot

Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

> Please rename "DbusHelper" to something that describes what the module is
> doing though. The fact that it uses D-Bus in the background is an
> implementation detail that shouldn't be exposed to users of the API.

Just out of academic curiosity, does this matter that much as it's private API anyway?
All these modules are installed under
/usr/lib/<arch>/ubuntu-system-settings/private/
and are not available to 3rd party applications.

« Back to merge proposal