Code review comment for lp:~unity-api-team/ubuntu-system-settings/apneditor

Here's the design review.

------

Thanks for helping me get the APN settings going on my handset. For
your convenience, I've attached a couple of screenshots of what I see.
Comparing the current implementation with
<https://wiki.ubuntu.com/Networking#apn-mobile>:

* "On the carrier screen, the “APN” item should be insensitive
    whenever the SIM is not associated with a carrier."

    When I'm in Flight Mode, (a) the carrier menu is empty, but (b) the
    "APN" item is still choosable. At least one of those is wrong
    (possibly both).

* On the APN screen, the radio lists are in Ubuntu shapes. If these
    are quick to remove, please remove them. Compare with the
    "Automatically"/"Manually" list on the Cellular screen, which
    looks much nicer.

* "The “Internet APN:” and “MMS APN:” radio lists should each consist
    of: * a “None” item, if no APN is currently activated for that
    connection type;..."

    On my handset, there are two items in the "Internet APN:" list, but
    neither of them are selected. If it's really true that no Internet
    APN is set on my phone, there should be a selected "None" item.

* Consequently, in the "MMS APN:" list, if I tap "Same APN as for
    Internet", I get a dialog: "Error: No Internet APN has been
    selected." Abolish this dialog, and instead just make that "Same
    APN" item insensitive whenever no Internet APN is selected.

* "Choosing “Custom Internet APN…” or “Custom MMS APN…” should open
    the relevant dialog..."

    These screens are currently stack pages instead of dialogs. This
    means that I can enter some settings, complete or not, then tap
    the Back button, and it isn't clear whether those settings will be
    saved or not, which is pretty confusing. Even worse, in the "Custom
    MMS APN" screen, the "Password" field is hidden partly under the
    "Cancel" and "Save" buttons, and partly under the OSK. And the
    field labels are weirdly close to the left edge of the screen.

* "“Internet APN”, “MMS APN”, “MMSC”, and “Proxy” should be URL
    fields (using the URL OSK and ignoring non-URL characters)..."

    Currently, "Internet APN", "MMS APN", "MMSC", and "Proxy" are all
    normal text fields, allowing impossible characters, and assuming
    that I want to capitalize and spell-check their contents when I do
    not.

* "...auto-inserting http:// on unfocus if no protocol was entered."

    This doesn't happen.

* When I tap "Activate", even after entering a non-existent APN name,
    the settings are apparently accepted without being tried.

Though I'm a perfectionist, I have a low bar for whether a feature is
better than nothing. But that last point is what makes me say no, this
isn't ready to land. If custom APNs aren't implemented at all yet, the
buttons and screens to specify them shouldn't be present, because
that's actively misleading. And if they are implemented, why is a
non-existent APN accepted?