Merge lp:~unity-api-team/indicator-network/increase-dbus-timeouts into lp:indicator-network/14.10

Proposed by Antti Kaijanmäki
Status: Rejected
Rejected by: Antti Kaijanmäki
Proposed branch: lp:~unity-api-team/indicator-network/increase-dbus-timeouts
Merge into: lp:indicator-network/14.10
Diff against target: 204 lines (+21/-21)
4 files modified
src/connectivity-cpp/dbus-cpp/services/nm.h (+6/-6)
src/connectivity-cpp/dbus-cpp/services/urfkill.h (+3/-3)
src/dbus-cpp/services/connectivity.h (+1/-1)
src/dbus-cpp/services/ofono.h (+11/-11)
To merge this branch: bzr merge lp:~unity-api-team/indicator-network/increase-dbus-timeouts
Reviewer Review Type Date Requested Status
Jussi Pakkanen (community) Approve
Review via email: mp+239505@code.launchpad.net

Commit message

Increase the default timeouts to match industry standards.

To post a comment you must log in.
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

Increase the default timeouts to match industry standards.

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Joojoo.

review: Approve
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Joojoo.

review: Approve
Revision history for this message
Antti Kaijanmäki (kaijanmaki) wrote :

Rejecting as out dated MP.

Unmerged revisions

459. By Antti Kaijanmäki

Increase the default timeouts to match industry standards.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/connectivity-cpp/dbus-cpp/services/nm.h'
--- src/connectivity-cpp/dbus-cpp/services/nm.h 2014-10-09 11:15:16 +0000
+++ src/connectivity-cpp/dbus-cpp/services/nm.h 2014-10-23 21:56:22 +0000
@@ -442,7 +442,7 @@
442442
443 static std::chrono::milliseconds default_timeout()443 static std::chrono::milliseconds default_timeout()
444 {444 {
445 return std::chrono::seconds{1};445 return std::chrono::seconds{30};
446 }446 }
447 };447 };
448 };448 };
@@ -508,7 +508,7 @@
508508
509 static std::chrono::milliseconds default_timeout()509 static std::chrono::milliseconds default_timeout()
510 {510 {
511 return std::chrono::seconds{1};511 return std::chrono::seconds{30};
512 }512 }
513 };513 };
514 };514 };
@@ -655,7 +655,7 @@
655655
656 static std::chrono::milliseconds default_timeout()656 static std::chrono::milliseconds default_timeout()
657 {657 {
658 return std::chrono::seconds{1};658 return std::chrono::seconds{30};
659 }659 }
660 };660 };
661 };661 };
@@ -752,7 +752,7 @@
752752
753 static std::chrono::milliseconds default_timeout()753 static std::chrono::milliseconds default_timeout()
754 {754 {
755 return std::chrono::seconds{1};755 return std::chrono::seconds{30};
756 }756 }
757 };757 };
758758
@@ -769,7 +769,7 @@
769769
770 static std::chrono::milliseconds default_timeout()770 static std::chrono::milliseconds default_timeout()
771 {771 {
772 return std::chrono::seconds{1};772 return std::chrono::seconds{30};
773 }773 }
774 };774 };
775775
@@ -786,7 +786,7 @@
786786
787 static std::chrono::milliseconds default_timeout()787 static std::chrono::milliseconds default_timeout()
788 {788 {
789 return std::chrono::seconds{1};789 return std::chrono::seconds{30};
790 }790 }
791 };791 };
792792
793793
=== modified file 'src/connectivity-cpp/dbus-cpp/services/urfkill.h'
--- src/connectivity-cpp/dbus-cpp/services/urfkill.h 2014-09-26 12:31:22 +0000
+++ src/connectivity-cpp/dbus-cpp/services/urfkill.h 2014-10-23 21:56:22 +0000
@@ -162,7 +162,7 @@
162162
163 static std::chrono::milliseconds default_timeout()163 static std::chrono::milliseconds default_timeout()
164 {164 {
165 return std::chrono::seconds{15};165 return std::chrono::seconds{30};
166 }166 }
167 };167 };
168168
@@ -179,7 +179,7 @@
179179
180 static std::chrono::milliseconds default_timeout()180 static std::chrono::milliseconds default_timeout()
181 {181 {
182 return std::chrono::seconds{15};182 return std::chrono::seconds{30};
183 }183 }
184 };184 };
185185
@@ -196,7 +196,7 @@
196196
197 static std::chrono::milliseconds default_timeout()197 static std::chrono::milliseconds default_timeout()
198 {198 {
199 return std::chrono::seconds{5};199 return std::chrono::seconds{30};
200 }200 }
201 };201 };
202 };202 };
203203
=== modified file 'src/dbus-cpp/services/connectivity.h'
--- src/dbus-cpp/services/connectivity.h 2014-08-07 21:14:42 +0000
+++ src/dbus-cpp/services/connectivity.h 2014-10-23 21:56:22 +0000
@@ -126,7 +126,7 @@
126126
127 static std::chrono::milliseconds default_timeout()127 static std::chrono::milliseconds default_timeout()
128 {128 {
129 return std::chrono::seconds{1};129 return std::chrono::seconds{30};
130 }130 }
131 };131 };
132 };132 };
133133
=== modified file 'src/dbus-cpp/services/ofono.h'
--- src/dbus-cpp/services/ofono.h 2014-10-09 10:58:30 +0000
+++ src/dbus-cpp/services/ofono.h 2014-10-23 21:56:22 +0000
@@ -61,7 +61,7 @@
6161
62 static std::chrono::milliseconds default_timeout()62 static std::chrono::milliseconds default_timeout()
63 {63 {
64 return std::chrono::seconds{1};64 return std::chrono::seconds{30};
65 }65 }
66 };66 };
67 };67 };
@@ -277,7 +277,7 @@
277277
278 static std::chrono::milliseconds default_timeout()278 static std::chrono::milliseconds default_timeout()
279 {279 {
280 return std::chrono::seconds{1};280 return std::chrono::seconds{30};
281 }281 }
282 };282 };
283 struct SetProperty283 struct SetProperty
@@ -293,7 +293,7 @@
293293
294 static std::chrono::milliseconds default_timeout()294 static std::chrono::milliseconds default_timeout()
295 {295 {
296 return std::chrono::seconds{1};296 return std::chrono::seconds{30};
297 }297 }
298 };298 };
299299
@@ -310,7 +310,7 @@
310310
311 static std::chrono::milliseconds default_timeout()311 static std::chrono::milliseconds default_timeout()
312 {312 {
313 return std::chrono::seconds{1};313 return std::chrono::seconds{30};
314 }314 }
315 };315 };
316316
@@ -327,7 +327,7 @@
327327
328 static std::chrono::milliseconds default_timeout()328 static std::chrono::milliseconds default_timeout()
329 {329 {
330 return std::chrono::seconds{1};330 return std::chrono::seconds{30};
331 }331 }
332 };332 };
333333
@@ -344,7 +344,7 @@
344344
345 static std::chrono::milliseconds default_timeout()345 static std::chrono::milliseconds default_timeout()
346 {346 {
347 return std::chrono::seconds{1};347 return std::chrono::seconds{30};
348 }348 }
349 };349 };
350350
@@ -361,7 +361,7 @@
361361
362 static std::chrono::milliseconds default_timeout()362 static std::chrono::milliseconds default_timeout()
363 {363 {
364 return std::chrono::seconds{1};364 return std::chrono::seconds{30};
365 }365 }
366 };366 };
367367
@@ -378,7 +378,7 @@
378378
379 static std::chrono::milliseconds default_timeout()379 static std::chrono::milliseconds default_timeout()
380 {380 {
381 return std::chrono::seconds{1};381 return std::chrono::seconds{30};
382 }382 }
383 };383 };
384 };384 };
@@ -814,7 +814,7 @@
814814
815 static std::chrono::milliseconds default_timeout()815 static std::chrono::milliseconds default_timeout()
816 {816 {
817 return std::chrono::seconds{1};817 return std::chrono::seconds{30};
818 }818 }
819 };819 };
820 struct SetProperty820 struct SetProperty
@@ -830,7 +830,7 @@
830830
831 static std::chrono::milliseconds default_timeout()831 static std::chrono::milliseconds default_timeout()
832 {832 {
833 return std::chrono::seconds{1};833 return std::chrono::seconds{30};
834 }834 }
835 };835 };
836 };836 };
@@ -1204,7 +1204,7 @@
12041204
1205 static std::chrono::milliseconds default_timeout()1205 static std::chrono::milliseconds default_timeout()
1206 {1206 {
1207 return std::chrono::seconds{1};1207 return std::chrono::seconds{30};
1208 }1208 }
1209 };1209 };
1210 };1210 };

Subscribers

People subscribed via source and target branches