Code review comment for lp:~unity-api-team/indicator-network/hotspot-cellular-enabled-properties

Revision history for this message
Jonas G. Drange (jonas-drange) wrote :

Does this scale at all? We should be making determinations about what device can have hotspot based on its capabilities—not the device name (are there no flo devices with modems, e.g.?)

I think this also makes the API ambiguous: we now have hotspotEnabled, hotspotSwitchEnabled, hotspotAvailable and hotspotStored. To be blunt, we'd need a logical matrix to determine what to show as enabled/disabled/populated/N/A in the UI.

For mako, we should try to fix the actual bugs that are causing the hotspot to fail, and for flo wee need enumerated capabilities from somewhere (SDK) in order to hide the hotspot (and cellular, phone) entry.

review: Disapprove

« Back to merge proposal