Code review comment for lp:~unity-api-team/indicator-network/fix_unlock_all

Revision history for this message
Charles Kerr (charlesk) wrote :

This patch is kind of tortured, but after talking it through with Antti I agree this is a good approach given the tight schedule and the need to know that the patch should be safe.

It would be preferable if a future revision fixes the workarounds described in the comment in SimUnlockDialog::Private::reset()

review: Approve

« Back to merge proposal