Code review comment for lp:~unity-api-team/indicator-network/data_usage_indication

Revision history for this message
Marcus Tomlinson (marcustomlinson) wrote :

Well... To be clear, what I was referring to by "looks good" is the diff and the outcome that was intended by it.

What doesn't look good is the icon popping up and disappearing between indicators. I think this is fine for a first iteration on this feature, but some serious design considerations need to be made. E.g. (I realise that we're currently limited to displaying icons only within our icon group, but) clearly what would look better is for the activity icon to appear in the left-most position as to avoid shifting indicators around each time it's shown.

Anyway, point is, I anticipate that there's still be some work to be done here, but as for building an MVP, looks good :)

Thanks Antti!

« Back to merge proposal