Code review comment for lp:~unity-api-team/indicator-network/connectivity-service

Revision history for this message
Charles Kerr (charlesk) wrote :

Source LGTM. There are some hacks in there to get DBus introspection working, but since this is an interim solution until dbus-cpp adds service-side introspection support, that's reasonable.

As before, I don't have multisim and am approving only based on code inspection; please don't merge until actual dual sim testing has been done.

review: Approve

« Back to merge proposal